ci: surface errors in subtree update report step#1018
Merged
Conversation
The report step silently swallowed failures by redirecting stderr to /dev/null and using || true. When the swift package command failed, REPORT_FILE was empty, jq returned "null", and the step exited with "No update available" — hiding the real error. Changes: - Capture stderr to a temp file instead of /dev/null - Track exit code explicitly instead of || true - Emit ::warning:: with stderr on unexpected exit codes - Validate JSON output before parsing with jq - Use jq '// empty' to avoid literal "null" string comparison
csjones
force-pushed
the
FIX-SUBTREE-UPDATE-CHECK
branch
from
1519d6e to
1cdabeb
Compare
added 3 commits
March 3, 2026 19:31
Add debug steps before/after subtree update to capture git state, trailers, and working tree status. Capture stdout/stderr from subtree update command and emit error annotations on failure. Change downstream step conditions from checking branch_name to checking update.outcome == 'success' to prevent execution when update fails.
Change branch creation and commit counting to reference origin/main instead of local main branch. This ensures the workflow operates against the remote state rather than potentially stale local refs, fixing issues where local main may not be up-to-date with the remote repository.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The report step silently swallowed failures by redirecting stderr to /dev/null and using || true. When the swift package command failed, REPORT_FILE was empty, jq returned "null", and the step exited with "No update available" — hiding the real error.
Changes: