Skip to content

Update date bugs#16

Open
muazhari wants to merge 1 commit into26medias:masterfrom
muazhari:master
Open

Update date bugs#16
muazhari wants to merge 1 commit into26medias:masterfrom
muazhari:master

Conversation

@muazhari
Copy link
Contributor

@muazhari muazhari commented Mar 26, 2021

What I did:

  • Remove unused library.
  • Change regression_forecast method from using date class operator overloading to the basic method.
  • Add data options to the regression_forecast method.

What I found:

  • I think this code below in the regression_forecast method should be fixed. Because when the sample is defined and not the same as real data, it should not see another data except the sample right? and should not calculate from that too.
var mean = this.mean(options.data);

@muazhari
Copy link
Contributor Author

hello, can my pull request get merged? because there has an unremoved unused third party library that will make the usage of this library dwindled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant