Conversation
Introduces a new property `PinnacleTouch.rev2025`. the following functionality is affected on the trackpads where this property returns True: - `sample_rate` cannot exceed 100 - `detect_finger_stylus()` is non-operational - `tune_edge_sensitivity()` is non-operational - `calibration_matrix` is non-operational Other changes involve house keeping chores like - spelling fixes - pre-commit hook updates - formatting changes - doc updates
and some other review changes
This is to prevent infinite loops during future experiments
Owner
Author
|
I just confirmed (with Linux) that trackpads using older firmware (via SPI & I2C) still works with these changes. |
adafruit-adabot
added a commit
to adafruit/CircuitPython_Community_Bundle
that referenced
this pull request
Apr 13, 2025
Updating https://github.com/2bndy5/CircuitPython_Cirque_Pinnacle to 2.0.0 from 1.0.0: > Bump pypa/gh-action-pypi-publish from 1.10.3 to 1.12.4 (2bndy5/CircuitPython_Cirque_Pinnacle#13) > compensate for newer (undocumented) firmware (2bndy5/CircuitPython_Cirque_Pinnacle#15) > prepare for trusted publisher releases > Bump actions/upload-artifact from 3 to 4 (2bndy5/CircuitPython_Cirque_Pinnacle#9) > Bump actions/setup-python from 4 to 5 (2bndy5/CircuitPython_Cirque_Pinnacle#7) > switch from pylint to ruff (2bndy5/CircuitPython_Cirque_Pinnacle#8) > Bump actions/checkout from 3 to 4 (2bndy5/CircuitPython_Cirque_Pinnacle#6) > use dependabot, update CI triggers, fix RTD builds (2bndy5/CircuitPython_Cirque_Pinnacle#5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking Change
The trackpad's DataReady (DR) is now a required parameter for the constructors.
Support for new trackpad firmware
Introduces a new property
PinnacleTouch.rev2025. The following functionality is affected on the trackpads where this property returnsTrue:sample_ratecannot exceed 100detect_finger_stylus()is non-operationaltune_edge_sensitivity()is non-operationalcalibration_matrixis non-operationalset_adc_gain()is non-operationalChores
Other changes involve house keeping chores like
Contributors
Special thanks to @ramensum for bringing this to my attention and hardware testing.