Skip to content

Comments

Update build.yml#4166

Merged
2dust merged 1 commit intomasterfrom
unknown repository
Dec 21, 2024
Merged

Update build.yml#4166
2dust merged 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Dec 21, 2024

github not use Flavors.

@2dust 2dust merged commit b5f182d into 2dust:master Dec 21, 2024
1 check passed
@UjuiUjuMandan
Copy link
Contributor

UjuiUjuMandan commented Dec 21, 2024

@2dust Sorry, please revert this. It's necessary for Reproducible Builds.

The workflow is like this:

  1. GitHub Actions builds and uploads the APKs of both flavors to releases, one is with -fdroid suffix, the other is not.
  2. fdroidserver builds the APKs of fdroid flavors.
  3. fdroidserver fetches your APKs with -fdroid suffix from GitHub Releases.
  4. fdroidserver compares them. If passed, releases it with copying your signatures.

@UjuiUjuMandan
Copy link
Contributor

UjuiUjuMandan commented Dec 21, 2024

The sed patching is really unnecessary; I have only seen downstream patches of upstream; how opposite?

@UjuiUjuMandan
Copy link
Contributor

UjuiUjuMandan commented Dec 21, 2024

I'll revert that after the veery slow diffoscope completed.

2dust added a commit that referenced this pull request Dec 21, 2024
@ghost
Copy link
Author

ghost commented Dec 22, 2024

😂a little trouble, all right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants