Conversation
I would like us to eventually move to Tornado (from fastapi) to be consistent with what we use in the JupyterHub ecosystem. One part of that is to make all network stuff async, and this moves us from `requests` to `aiohttp`, making everything async as needed as we go. This isn't complete, a WIP.
Start putting all the prometheus related stuff into one class that we can then configure with Traitlets. This moves us into being able to put all the AWS stuff into one class too, and then that is how we can make this generic enough for cloud providers
yuvipanda
marked this pull request as draft
July 22, 2026 22:59
yuvipanda
changed the title
Member
Author
|
Too many refactors at once! #120 is cleaner |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Start putting all the prometheus related stuff into one class
that we can then configure with Traitlets. This moves us into
being able to put all the AWS stuff into one class too, and then
that is how we can make this generic enough for cloud providers