Migrate jQuery code to native JavaScript - #11
Merged
Conversation
This change will migrate the code for the Classic Editor from jQuery to native JavaScript. Since the `URLSearchParams` object converts arrays with a single to a scalar type, the PHP code needed to be updated as well.
2ndkauboy
commented
Feb 12, 2025
| function ( data ) { | ||
| jQuery( '#unique-title-message' ).remove(); | ||
| document.addEventListener( "DOMContentLoaded", function () { | ||
| document.getElementById( "title" ).addEventListener( "blur", function () { |
Owner
Author
There was a problem hiding this comment.
Wrap these into multiple lines (PHPCS)
| post_id: document.getElementById( "post_ID" ).value, | ||
| post_type: document.getElementById( "post_type" ).value, | ||
| post_title: title | ||
| } ); |
Owner
Author
There was a problem hiding this comment.
Wrap these in multiple lines as well.
| ); | ||
| } | ||
| } | ||
| if (data.status === "error" || !unique_title_checker.only_unique_error) { |
Owner
Author
There was a problem hiding this comment.
Add "globals" to get rid of the warnings.
2ndkauboy
commented
Feb 12, 2025
Comment on lines
+35
to
+37
| `<div id="unique-title-message" class="${ data.status }"> | ||
| <p>${ data.message }</p> | ||
| </div>` |
Owner
Author
There was a problem hiding this comment.
Maybe wrap in multiple lines.
Owner
Author
|
Maybe also fix #10 |
2ndkauboy
force-pushed
the
feature/remove-jquery-for-classic-editor
branch
from
July 29, 2025 14:27
910f739 to
3a9b273
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.