-
-
Notifications
You must be signed in to change notification settings - Fork 10
Probably compatible for newer versions #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Nice job. 等我再测试一下看看 |
|
NeoForge问题已解决,Forge读取版本仍有问题 |
|
@M3MEMonster I'm fixing the NeoForge & Forge problem. NeoForge 1.21.9+ uses a completely different framework than |
|
Plus, @3093FengMing please note that there are tons of unsafe |
|
Oh, you speak English. What I mean is NeoForge's issue has been solved by your newest patch, and in Forge environment, VP can read the version but it still has problem that VP can't recognize it well. |
|
@M3MEMonster No need to transplant to NilLoader -- no major modding platform needs a javaagent for |
|
对于高性能消耗的
不应该假定文件名是不变的,且用 对于游戏内调整游戏语言的情形,本模组没有考虑到。不过出于避免与Vanilla Code交互,以及避免动态读取的理念,我们暂且放下不提。 |
|
I was speaking English because I was afraid that if I switch to Chinese I couldn't help criticizing everything. Basically, the codebase is still quite similar to the 2022 SpeedABC mod. I don't think I'm capable of rewriting something like that anymore. |
我跟作者商量来着,apply mod和classes都应移除,但是我尝试过简单粗暴的移除之后模组直接无法运行,当时的主要优先级是添加ArrayProducer和日志优化,暂时就没动。况且比起你们我是个妥妥的半吊子选手,我是学经济的,而且我入门是Python,写Java代码基本纯靠英文基础,对于底层算法优化线程调度等更是纯小白,只是因为我目前时间相对充足,对编程相对感兴趣,我一直在用这个mod所以也在contribute。有批评尽管说,正好我也学学。 |
|
@teddyxlandlee 1.21.9以前的NeoForge环境下,游戏在早期崩溃 高版本Forge环境能够正确读取MC版本,游戏正常启动,但是日志里出现Unable to create custom ContextSelector报错且跟随大量关于 Unable to create Lookup for bundle java.lang.ClassCastException: class org.apache.logging.log4j.core下的所有模块的报错 2025-11-25T16:28:41.133650500Z main ERROR Unable to create Lookup for bundle java.lang.ClassCastException: class org.apache.logging.log4j.core.lookup.ResourceBundleLookup 2025-11-25T16:28:41.135650700Z main ERROR Unable to create Lookup for ctx java.lang.ClassCastException: class org.apache.logging.log4j.core.lookup.ContextMapLookup |

This PR:
defineClassmethod in Java 9+, by moving the inner class tome.fengming.vaultpatcher_asm.core.transformerspackage, marking synthetic, and defining viaMethodHandles.Lookup.defineClass()java.io -> java.nio.fileExpected to run on 1.21.10 (and 25w45a_unobfuscated) on all platforms. Not tested, the mod has too many functions that I don't think I can cover the edge cases in limited time.