Skip to content

Support editing a property of type array without oneOf like animation startEvents #1572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vincentfretin wants to merge 1 commit into from
Closed

Support editing a property of type array without oneOf like animation startEvents #1572

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/editor/components/elements/PropertyRow.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,14 +68,29 @@ export default class PropertyRow extends React.Component {
? props.entity.getDOMAttribute(props.componentname)?.[props.name]
: props.data;

const isFreeInputArray =
type === 'array' &&
!(props.schema.oneOf && props.schema.oneOf.length > 0);

if (type === 'string' && value && typeof value !== 'string') {
// Allow editing a custom type like event-set component schema
value = props.schema.stringify(value);
} else if (isFreeInputArray && Array.isArray(value)) {
// InputWidget expects a string. Use the schema stringify to get a
// consistent ", "-separated representation. Skipped when oneOf is set
// because SelectWidget needs the raw array to compute selected options.
value = props.schema.stringify(value);
}

const widgetProps = {
name: props.name,
onChange: function (name, value) {
if (isFreeInputArray && typeof value === 'string') {
// Parse comma-separated string back to array so EntityUpdateCommand's
// schemaProperty.stringify(value) can call .join() on it.
value = props.schema.parse(value);
}

// Auto-switch to custom variant for building segments when modifying certain properties
const shouldSwitchToCustom =
// Surface changes on street-segment
Expand Down
Loading