feat(git): Use AMR mode for diff-filter option#301
Open
gheritarish wants to merge 1 commit into
Open
Conversation
Currently, the diff-filter option in the `git diff command is AR. This means that only added or renamed files are taken into account. However, in a case where a migration is updated, we want to be able to lint it anyways. So, changing the diff-filter mode to AMR should take that into account.
Author
|
Sorry for opening a PR without opening an issue beforehand, I encountered this behaviour in a specific case, and thought it would be nice to have it everywhere. Fell free to discard this PR if it feels useless, or to tell me if you'd want an option to use either the AR diff-filter option, or the AMR diff-filter option. |
|
I ran in to this too and would like to see this change! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the diff-filter option in the `git diff command is AR. This means that only added or renamed files are taken into account.
However, in a case where a migration is updated, we want to be able to lint it anyways. So, changing the diff-filter mode to AMR should take that into account.