-
Notifications
You must be signed in to change notification settings - Fork 54
Add Livox Avia in scanners_tls.xml #696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jqnm
wants to merge
8
commits into
main
Choose a base branch
from
add-livox-avia-in-tls-scanners
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #696 +/- ##
==========================================
+ Coverage 66.42% 67.09% +0.67%
==========================================
Files 485 485
Lines 16640 15395 -1245
Branches 1741 1740 -1
==========================================
- Hits 11053 10330 -723
+ Misses 5587 5065 -522 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Awesome, thanks @jqnm Some first comments/additions:
|
Updated the rangeMin_m to 3 m and the beam divergence to 0.001 rad. Also added the rangeMax_m (450 m). All based on the specs from the L2 datasheet
Added maxNOR and rangeMax_m according to Avia data sheet
Collaborator
Author
Everything is done, except the last comment |
…on-repetitive scan pattern for Livox Avia in scanners_tls.xml
… scanners_als.xml
We need to specify the pulse frequency per channel. So if the scanner datasheet says 240,000, but we have 6 channel, it must be 40,000.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.