Skip to content

Conversation

@jqnm
Copy link
Collaborator

@jqnm jqnm commented Oct 9, 2025

No description provided.

@codecov
Copy link

codecov bot commented Oct 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.09%. Comparing base (6f51fac) to head (b468269).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #696      +/-   ##
==========================================
+ Coverage   66.42%   67.09%   +0.67%     
==========================================
  Files         485      485              
  Lines       16640    15395    -1245     
  Branches     1741     1740       -1     
==========================================
- Hits        11053    10330     -723     
+ Misses       5587     5065     -522     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@han16nah han16nah marked this pull request as draft October 9, 2025 16:54
@han16nah
Copy link
Contributor

han16nah commented Oct 10, 2025

Awesome, thanks @jqnm

Some first comments/additions:

  • Can you add "maxNOR" = "3" to the Livox Avia?
  • We could think about adding "maxRange_m" to the Livox Avia and DJI Zenmuse L2 scanners (cf. "Detection Range" in the datasheets)
  • I think the beam divergence of the Zenmuse L2 is wrong. If we take the bigger divergence of the elliptical footprint (given in https://enterprise.dji.com/de/zenmuse-l2/specs at the FWHM), it would be 0.001 rad, correct? Can you check and if so, add this?
  • We should also update the "rangeMin_m" of the L2 to 3 m, according to the datasheet.
  • Once the Livox Avia is validated, we can also add it to the scanners_als.xml, here I'd suggest to name it DJI Zenmuse L1

jqnm added 2 commits October 10, 2025 15:17
Updated the rangeMin_m to 3 m and the beam divergence to 0.001 rad. Also added the rangeMax_m (450 m). All based on the specs from the L2 datasheet
Added maxNOR and rangeMax_m according to Avia data sheet
@jqnm
Copy link
Collaborator Author

jqnm commented Oct 10, 2025

Awesome, thanks @jqnm

Some first comments/additions:

  • Can you add "maxNOR" = "3" to the Livox Avia?
  • We could think about adding "maxRange_m" to the Livox Avia and DJI Zenmuse L2 scanners (cf. "Detection Range" in the datasheets)
  • I think the beam divergence of the Zenmuse L2 is wrong. If we take the bigger divergence of the elliptical footprint (given in https://enterprise.dji.com/de/zenmuse-l2/specs at the FWHM), it would be 0.001 rad, correct? Can you check and if so, add this?
  • We should also update the "rangeMin_m" of the L2 to 3 m, according to the datasheet.
  • Once the Livox Avia is validated, we can also add it to the scanners_als.xml, here I'd suggest to name it DJI Zenmuse L1

Everything is done, except the last comment

jqnm and others added 5 commits October 23, 2025 12:55
…on-repetitive scan pattern for Livox Avia in scanners_tls.xml
We need to specify the pulse frequency per channel. So if the scanner datasheet says 240,000, but we have 6 channel, it must be 40,000.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants