This repository was archived by the owner on Feb 23, 2026. It is now read-only.
message_definitions: update+add LED_CONTROL_* messages#27
Open
message_definitions: update+add LED_CONTROL_* messages#27
Conversation
Contributor
|
this should totally be merged ! 👯 |
Contributor
Author
|
Who want's to do the honors. @liamstask? |
Contributor
Contributor
|
Please work on top of upstream ardupilotmega.xml from the ardupilot repository if possible. |
Contributor
|
Can these be implemented as COMMAND_LONGs? |
Contributor
Author
|
@liamstask The idea is for them to be generic, yes. @jschall: |
Contributor
|
We should probably merge upstream ardupilotmega.xml into this repository, preferably before merging this PR |
Contributor
|
Can you implement all of this on upstream? I've rebased these changes on the new ardupilotmega.xml file: https://github.com/jschall/ardupilot/tree/pr-led-control |
ec2ef35 to
8f7e006
Compare
Contributor
|
Went ahead and rebased this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LED_CONTROLmessageLED_CONTROL_PATTERN,LED_CONTROL_PATTERN_PARAM, andLED_CONTROL_MACROmessages for full low-level LED control.