Skip to content
This repository was archived by the owner on Feb 23, 2026. It is now read-only.

message_definitions: update+add LED_CONTROL_* messages#27

Open
Gussy wants to merge 3 commits intomasterfrom
oreoled-mavlink-control
Open

message_definitions: update+add LED_CONTROL_* messages#27
Gussy wants to merge 3 commits intomasterfrom
oreoled-mavlink-control

Conversation

@Gussy
Copy link
Copy Markdown
Contributor

@Gussy Gussy commented Dec 14, 2015

  • Removes the old (and totally un-used) LED_CONTROL message
  • Adds new LED_CONTROL_PATTERN, LED_CONTROL_PATTERN_PARAM, and LED_CONTROL_MACRO messages for full low-level LED control.

@mrpollo
Copy link
Copy Markdown
Contributor

mrpollo commented Jan 5, 2016

this should totally be merged ! 👯

@Gussy
Copy link
Copy Markdown
Contributor Author

Gussy commented Jan 5, 2016

Who want's to do the honors. @liamstask?

@liamstask
Copy link
Copy Markdown
Contributor

@Gussy: is this intended to be generalizable beyond oreoled? @mrpollo: do you have other plans for it, or just want better oreoled support?

@mrpollo, @jschall: is there any effort to sync w/upstream mavlink? if so, wondering if this should sync with that effort

@jschall
Copy link
Copy Markdown
Contributor

jschall commented Jan 5, 2016

Please work on top of upstream ardupilotmega.xml from the ardupilot repository if possible.

@jschall
Copy link
Copy Markdown
Contributor

jschall commented Jan 5, 2016

Can these be implemented as COMMAND_LONGs?

@Gussy
Copy link
Copy Markdown
Contributor Author

Gussy commented Jan 6, 2016

@liamstask The idea is for them to be generic, yes.

@jschall:
I think rebasing this repo on upstream is for a different PR.
The largest payload is 15 bytes, so these could be COMMAND_LONGs, should I re-write this and the ardupilot-solo patch?

@jschall
Copy link
Copy Markdown
Contributor

jschall commented Jan 6, 2016

We should probably merge upstream ardupilotmega.xml into this repository, preferably before merging this PR

@jschall
Copy link
Copy Markdown
Contributor

jschall commented Jan 6, 2016

Can you implement all of this on upstream?

I've rebased these changes on the new ardupilotmega.xml file: https://github.com/jschall/ardupilot/tree/pr-led-control

@jschall jschall force-pushed the oreoled-mavlink-control branch from ec2ef35 to 8f7e006 Compare January 6, 2016 23:45
@jschall
Copy link
Copy Markdown
Contributor

jschall commented Jan 6, 2016

Went ahead and rebased this PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants