Skip to content

PHPStan test with fixes, And PHP 8.4 Support#194

Open
erikn69 wants to merge 3 commits into
404labfr:masterfrom
erikn69:patch-2
Open

PHPStan test with fixes, And PHP 8.4 Support#194
erikn69 wants to merge 3 commits into
404labfr:masterfrom
erikn69:patch-2

Conversation

@erikn69

@erikn69 erikn69 commented Feb 29, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Working Demo: laravel-impersonate/actions/runs/phpstan

./vendor/bin/phpstan --error-format=github
Note: Using configuration file /home/runner/work/laravel-impersonate/laravel-impersonate/phpstan.neon.dist.

  0/15 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓]   0%
 15/15 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

Closes #217
Closes #228

@erikn69

erikn69 commented Mar 11, 2024

Copy link
Copy Markdown
Contributor Author

@MarceauKa hi, this is PHPStan test, and PHPDOC fixes

@erikn69 erikn69 force-pushed the patch-2 branch 4 times, most recently from 420de03 to cd9ee9a Compare February 6, 2025 16:19
@erikn69 erikn69 changed the title PHPStan test and fixes PHPStan test with fixes, And PHP 8.4 Support Feb 6, 2025
@erikn69

erikn69 commented Feb 6, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@MarceauKa hi, PHPStan updated to PHP 8.4, PHP 8.4 support added
https://github.com/404labfr/laravel-impersonate/actions/runs/13183271640/job/36799160422?pr=194

@parallels999

parallels999 commented Feb 24, 2025

Copy link
Copy Markdown

@MarceauKa hi, still there??

@MarceauKa

MarceauKa commented Feb 24, 2025

Copy link
Copy Markdown
Member

@MarceauKa hi, still there??

I am 😂

@parallels999

parallels999 commented Feb 24, 2025

Copy link
Copy Markdown

great, good to know, i was worried 😂

@parallels999 parallels999 mentioned this pull request Feb 26, 2025
Open
@PNardman

PNardman commented Mar 26, 2025

Copy link
Copy Markdown

Waiting for this. <3

@parallels999 parallels999 mentioned this pull request Mar 26, 2025
Open
@PNardman

PNardman commented Sep 24, 2025

Copy link
Copy Markdown

Any updates?

@parallels999 parallels999 mentioned this pull request Sep 24, 2025
Open
@PNardman

PNardman commented Oct 23, 2025

Copy link
Copy Markdown

Would be awesome if we could merge this as PHP 8.3 is entering security fixes only soon.

@PNardman

PNardman commented Feb 11, 2026 •
edited
Loading

Copy link
Copy Markdown

@MarceauKa any updates on if we can merge this, this would be very helpful in getting rid of deprecation logs on php 8.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Wrong PHPDoc type for id (int instead of int|string or mixed) causes PHPStan errors PHP 8.4 Deprecation warnings

4 participants

@erikn69 @parallels999 @MarceauKa @PNardman