add support to have multiple depths of impersonation#238
Open
ainesophaur wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed the ability to impersonate users at multiple depths and leave impersonate in the order that it was entered. This PR brings the functionality by creating a stack of impersonations saved in the session, keyed by guard.
The proposed change allows super user -> admin -> user and then subsequent calls to leave will unwind the stack, user -> admin, then admin -> super user. The current packages behavior only keeps the last "impersonator", so going further than one level of impersonation causes the existing impersonation identities to be discarded.
I added to tests to verify functionality but I can certainly add more if needed.