Skip to content

[visualizer] removed force https when loading replay files#191

Merged
PaulicStudios merged 1 commit intodevfrom
removed-force-https
Mar 14, 2026
Merged

[visualizer] removed force https when loading replay files#191
PaulicStudios merged 1 commit intodevfrom
removed-force-https

Conversation

@PaulicStudios
Copy link
Member

@PaulicStudios PaulicStudios commented Mar 14, 2026

So that a local s3 bucket storage for local website testing also works

Summary by CodeRabbit

  • Bug Fixes
    • Simplified URL protocol handling in replay loading functionality.

@coderabbitai
Copy link

coderabbitai bot commented Mar 14, 2026

📝 Walkthrough

Walkthrough

The forceHttps helper function was removed from replayLoader.ts along with all its usages. Fetch calls now use raw file paths directly without explicit HTTPS protocol enforcement, altering how request protocols are handled throughout the module.

Changes

Cohort / File(s) Summary
Protocol handling refactoring
visualizer/src/ts/replay_loader/replayLoader.ts
Removed forceHttps helper function and its usages in fetch calls (loadReplay, setupReplayLoader, and update checks). Requests now use raw filePath without explicit HTTPS upgrade.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A rabbit's refrain on the protocol lane:

We hopped from HTTPS chains,
Now raw paths light the way,
No forced protocol strains,
The fetch calls can play!
Simple protocols stay. 🌐✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removing the forceHttps helper function and eliminating explicit HTTPS-upgrading behavior in replay file loading.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch removed-force-https
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can disable poems in the walkthrough.

Disable the reviews.poem setting to disable the poems in the walkthrough.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@visualizer/src/ts/replay_loader/replayLoader.ts`:
- Around line 116-117: The fetch in replayLoader.ts uses a user-controlled
filePath from query params without validation; add a URL
validation/normalization step (using the URL constructor) before calling fetch
to ensure the replay source is a single allowed origin/protocol (e.g.,
same-origin or https only) and normalize relative paths to the app origin; if
validation fails, reject/throw and do not call fetch. Update the code path that
receives the param in main.ts to use the same validation helper so only a single
normalized, allowed URL reaches replayLoader.load (or the function that calls
fetch), and log a clear error when an invalid URL is provided.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9aa5f0c7-8899-42fb-8d79-1d8771d15c35

📥 Commits

Reviewing files that changed from the base of the PR and between 1059b1c and 9555c34.

📒 Files selected for processing (1)
  • visualizer/src/ts/replay_loader/replayLoader.ts

@PaulicStudios PaulicStudios merged commit e24f12e into dev Mar 14, 2026
5 checks passed
@PaulicStudios PaulicStudios deleted the removed-force-https branch March 14, 2026 20:21
PaulicStudios added a commit that referenced this pull request Mar 23, 2026
* [visualizer] removed force https when loading replay files (#191)

* deleted dublicate go client lib, put go.mod into root, fix paths in
dockerfile

* [bots|go] refactor: renamed template to softcore

* removed post create cmd as ./../../client_lib works both in the monorepo
and in the devcontainer itself.
removed cpp addons

* reverted back changes that got lost from deleting the duplicate
client_lib

* [monorepo] added go language support to root makefile

* [bots|go] fix basic connection so that client lib connects and ticks
play out
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants