Merged
Conversation
…y get assigned as reviewer
Update CODEOWNERS to properly fix path rules
FreddyMSchubert
added
the
monorepo
PaulicStudios
approved these changes
Aug 26, 2025
Member
|
What merge rules are these that even after a review nobody can merge? |
Member
Author
|
really weird i dont know why lemme check |
Member
Author
|
Yeah that was badly configured my bad. Should be better now. |
Member
Author
|
Literally nobody that didn't have bypass permissions could update. Maybe we should keep that for main though? Literally only give organization owners permission to ship stuff to prod. Sounds good Imma do that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alright seems to work very cool. Now we can give specific GitHub usernames responsibility over certain parts of the code and they will be marked as reviewers if that code was changed and can't be removed.
Config is in .github/CODEOWNERS
Dear Paul please review and merge this highly important PR