-
Notifications
You must be signed in to change notification settings - Fork 4
feat: Implement structured logging with NestJS Pino and a global exce… #559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
d8c3827
feat: Implement structured logging with NestJS Pino and a global exce…
PaulicStudios 0e27284
refactor: enhance error logging and exception handling across control…
PaulicStudios a73216f
Merge pull request #576 from 42core-team/dependabot/github_actions/al…
PaulicStudios 73eb34c
fix: double error loggin
PaulicStudios File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| import { | ||
| ExceptionFilter, | ||
| Catch, | ||
| ArgumentsHost, | ||
| HttpException, | ||
| HttpStatus, | ||
| Logger, | ||
| } from "@nestjs/common"; | ||
| import { HttpAdapterHost } from "@nestjs/core"; | ||
|
|
||
| @Catch() | ||
| export class AllExceptionsFilter implements ExceptionFilter { | ||
| private readonly logger = new Logger(AllExceptionsFilter.name); | ||
|
|
||
| constructor(private readonly httpAdapterHost: HttpAdapterHost) {} | ||
|
|
||
| catch(exception: unknown, host: ArgumentsHost): void { | ||
| const { httpAdapter } = this.httpAdapterHost; | ||
| const ctx = host.switchToHttp(); | ||
coderabbitai[bot] marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| const httpStatus = | ||
| exception instanceof HttpException | ||
| ? exception.getStatus() | ||
| : HttpStatus.INTERNAL_SERVER_ERROR; | ||
|
|
||
| const responseBody = { | ||
| statusCode: httpStatus, | ||
| timestamp: new Date().toISOString(), | ||
| path: httpAdapter.getRequestUrl(ctx.getRequest()), | ||
| message: | ||
| exception instanceof HttpException | ||
| ? exception.message | ||
| : "Internal server error", | ||
| }; | ||
|
|
||
| if (httpStatus >= 500) { | ||
| if (exception instanceof Error) { | ||
| this.logger.error(exception.message, exception.stack); | ||
| } else { | ||
| this.logger.error(`Unhandled Exception: ${exception}`); | ||
| } | ||
| } else { | ||
| // 4xx errors | ||
| if (exception instanceof Error) { | ||
| this.logger.warn( | ||
| `HTTP Exception: ${exception.message}`, | ||
| exception.stack, | ||
| ); | ||
| } else { | ||
| this.logger.warn(`HTTP Exception: ${exception}`); | ||
| } | ||
| } | ||
|
|
||
| httpAdapter.reply(ctx.getResponse(), responseBody, httpStatus); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -88,5 +88,4 @@ export class CreateEventDto { | |
| @ApiProperty() | ||
| @IsBoolean() | ||
| isPrivate: boolean; | ||
|
|
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -102,4 +102,3 @@ export class UpdateEventSettingsDto { | |
| @IsString() | ||
| serverConfig?: string; | ||
| } | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.