Add a new user/beginner friendly errors system#505
Add a new user/beginner friendly errors system#505NiumXp wants to merge 16 commits into42school:masterfrom
Conversation
This reverts commit a88f7fb, since it broke tests and flake8.
…rmatter the new style with colors and arrows
|
Subjective nit, this should probably have a bit more padding for readability's sake. Other than that, looks pretty amazing :) |
otto-mata
left a comment
There was a problem hiding this comment.
Overall a very good new feature, the norminette would really benefit from its addition!
Some changes are still necessary in my opinion, but please you are absolutely free to discuss your choices!
Bests,
tblochet
| # if len(item) == 2: | ||
| # lineno, column = item | ||
| # return self._line_to_index[lineno + column] |
There was a problem hiding this comment.
See last comment, potentially breaking change
| from norminette.errors import Error, Errors, Highlight as H | ||
| from norminette.errors import HumanizedErrorsFormatter | ||
| from norminette.errors import ShortErrorsFormatter | ||
| # from norminette.errors import HumanizedErrorsFormatter |
Asandolo
left a comment
There was a problem hiding this comment.
Hello can you tell us if this PR is still relevant, if is it can you rebase and resolve all conflict ?
Have a nice day
|
Hello, @Asandolo! Thanks for checking in. Yep, this PR is still relevant! I’ll take care of the rebase and sort out the conflicts shortly. Really appreciate you reaching out. Hope your day’s going well! |
Hi, this is one of my drafts (maybe 7 months ago) focused on beginners (and quality of life) that I wrote for norminette when @matthieu42Network was accepting my PRs, I'm not sure if he's still available, but recently it seems like new people became collaborators, this made me happy and willing to continue with contributions.
New errors formatting
To use the new format is not necessary a new configuration, just run your norminette:
I added a red color to the errors:
