Fix incorrect regex for integer literals#563
Open
ef3d0c3e wants to merge 1 commit into42school:masterfrom
Open
Fix incorrect regex for integer literals#563ef3d0c3e wants to merge 1 commit into42school:masterfrom
ef3d0c3e wants to merge 1 commit into42school:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recently noticed that the regex responsible for parsing integer literals doesn't work as expected.
The prefix part of the regex matches for
[bBxX]*which caused any combination ofbBxXto be matched, instead of only matching repeating sequences: https://regex101.com/r/5lUQ0U/1In cases like
0xb0b;0xbis considered the prefix of the integer literal, causing the lastbto be matched as an invalid suffix.In the modified regex combinations can no longer match, only repetitions are allowed: https://regex101.com/r/nWkXWv/1
I'm not sure about how to run tests. The tests seems to fail on the current master branch. With more information, I might be able to add tests for this modified regex.
Verification Steps
Please ensure the following steps have been completed:
poetry run flake8to check for linting issues.poetry run pytestto ensure unit tests pass.poetry run toxto validate compatibility across Python versions.