Slack: auto-join channels regardless of legacy#2221
Open
Arusekk wants to merge 1 commit into42wim:masterfrom
Open
Slack: auto-join channels regardless of legacy#2221Arusekk wants to merge 1 commit into42wim:masterfrom
Arusekk wants to merge 1 commit into42wim:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I have not tested this code yet, very sorry, but it builds and I think it will allow auto-joining public channels regardless of whether the token is legacy-mode or not.
I am not sure of whether this logic makes sense. It looks like once upon a time some predecessor of the currently used join method would create a channel if missing, but the currently used conversations.join is documented to fail when there is no such channel. So I think it makes more sense to try to join the channel when the bot finds that it is not a member.
Anyway, please treat this more like an issue report with suggested direction of addressing the problem rather than a complete solution.