Skip to content

Feature/include file input#31

Merged
dragos-ana merged 1 commit into4C-multiphysics:mainfrom
LaSi5002:feature/include-file-input
Jan 19, 2026
Merged

Feature/include file input#31
dragos-ana merged 1 commit into4C-multiphysics:mainfrom
LaSi5002:feature/include-file-input

Conversation

@LaSi5002
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Collaborator

@dragos-ana dragos-ana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the nice addition!
I left some comments / questions.

Comment thread src/fourc_webviewer/fourc_webserver.py Outdated
Comment thread src/fourc_webviewer/fourc_webserver.py Outdated
Comment thread src/fourc_webviewer/fourc_webserver.py Outdated
Comment thread src/fourc_webviewer/fourc_webserver.py Outdated
Comment thread src/fourc_webviewer/fourc_webserver.py Outdated
Comment thread src/fourc_webviewer/fourc_webserver.py Outdated
Comment thread src/fourc_webviewer/fourc_webserver.py Outdated
Comment thread src/fourc_webviewer/fourc_webserver.py
Comment thread src/fourc_webviewer/fourc_webserver.py
Comment thread src/fourc_webviewer/gui_utils.py
Comment thread src/fourc_webviewer/fourc_webserver.py
Copy link
Copy Markdown
Collaborator

@dragos-ana dragos-ana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes requested. The most critical one concerns the symlinks, this must be fixed so that the tests can run.
Afterwards, please squash and we can merge this!
Thanks for your work!

Comment thread src/fourc_webviewer/gui_utils.py Outdated
Comment thread src/fourc_webviewer/fourc_webserver.py
Comment thread src/fourc_webviewer/fourc_webserver.py
Comment thread src/fourc_webviewer/fourc_webserver.py
Comment thread src/fourc_webviewer_default_files/tutorial_solid_vtu.4C.yaml Outdated
Comment thread src/fourc_webviewer/fourc_webserver.py Outdated
@LaSi5002 LaSi5002 force-pushed the feature/include-file-input branch from 9a0f551 to de61ede Compare December 22, 2025 19:48
@LaSi5002 LaSi5002 force-pushed the feature/include-file-input branch 2 times, most recently from a01a442 to 20506c3 Compare January 11, 2026 20:47
Comment thread src/fourc_webviewer/fourc_webserver.py
Copy link
Copy Markdown
Collaborator

@dragos-ana dragos-ana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that the tests are passing, please squash so that we can finally merge this!

@LaSi5002 LaSi5002 force-pushed the feature/include-file-input branch from 20506c3 to cccacd6 Compare January 18, 2026 21:03
@dragos-ana dragos-ana merged commit 6c5a483 into 4C-multiphysics:main Jan 19, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants