Check element maps too to decide if geometry needs an update in DiscretizationVisualizationWriterMesh#1794
Merged
vovannikov merged 1 commit into4C-multiphysics:mainfrom Mar 4, 2026
Conversation
Contributor
|
I think someone else should review this PR. I have no real experience with this part of the code. |
Contributor
|
Thanks for fixing this! Sounds reasonable to me, but I’m also not an expert in this part of the code. |
a468840 to
999ace2
Compare
999ace2 to
d99b9b3
Compare
isteinbrecher
approved these changes
Mar 3, 2026
georghammerl
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description and Context
It turned out, that checking only the node maps when deciding whether the update of the internal data structures inside
DiscretizationVisualizationWriterMeshis not sufficient. Some output implementations may produce only cell output and it may happen that the corresponding nodes remain intact whereas the elements get updated: in this situation an error is later triggered here:4C/src/core/io/src/4C_io_visualization_data.cpp
Lines 114 to 117 in 9e57490
This error was encountered by @mairehenke when working with a Taylor-Couette flow SPH benchmark of @slfuchs, I also then managed to reproduce it on a larger SPH benchmark.