feat: serialization audit and implementation - #22
Open
GallaGit wants to merge 6 commits into
Open
Conversation
Close undefined JSON contracts on auth, deletes, and incident analyze; slim list payloads and document every endpoint status. Co-authored-by: Cursor <cursoragent@cursor.com>
Keep API serialization evidence with other audit artifacts and update cross-references. Co-authored-by: Cursor <cursoragent@cursor.com>
Keep Lighthouse and serialization audit evidence with project docs and refresh path references. Co-authored-by: Cursor <cursoragent@cursor.com>
Split SupplierResponse from write models and stop echoing email on POST /users so every endpoint is fully serialized. Co-authored-by: Cursor <cursoragent@cursor.com>
Record verification evidence and close the audit checklist at 31/31 serialized endpoints. Co-authored-by: Cursor <cursoragent@cursor.com>
Point READMEs, tech context, and bitacora at the closed checklist and verification notes. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resumen
docs/audit/serialization-audit.md.response_modelPydantic explícito; se separan esquemas de entrada y salida (p. ej.SupplierResponsevsSupplierCreate,RegisterResponsesin email).message; registro sin email;GET /auth/mepuede devolver el email del llamante.IncidentListItem,InventoryOrderListItem) y evidencias de auditoría reubicadas endocs/audit/.Objetivo y alcance
Cerrar contratos de respuesta indefinidos en FastAPI para que el backend no exponga ORM/dict crudos ni campos sensibles, alineado con el consumo del backoffice.
Archivos principales
services/app/models/*,routers/*,schemas.py,domain/supplier_service.py,domain/user_service.pydocs/audit/serialization-audit.md,docs/audit/README.md,services/README(.es).md,memory-bank/*,bitacora.mduis/backoffice/types/auth.ts,incidentManager.ts,inventory.ts,lib/services/authApi.tsValidación
docker compose up --build: register sin email, login token-only,/auth/mecon email, suppliers, incidents lean, OpenAPIPOST /auth/login+GET /auth/mecon BearerRiesgos / seguimiento
docs/telemetry/no forma parte de esta PR (otro hito).MessageResponse.messageen lugar deDetailResponse.detail.Plan de prueba
docker compose up --buildo uvicorn local)POST /users→ body sinemailPOST /auth/login→ solo token;GET /auth/me→ email del usuariohttp://127.0.0.1:8000/docsGET /suppliers,GET /api/incidentscon BearerMade with Cursor