Skip to content

Conversation

@floriangantner
Copy link

@floriangantner floriangantner commented May 2, 2024

References

Description

New configuration value discovery.index.securitylevel.maxlevel. All (non-null) securitylevel above this value are skipped during indexing. The default value is 0.

Instructions for Reviewers

List of changes in this PR:

  • added configuration
  • added check in itemindex factory to skip metadatavalues with some security level greater than the expected limit
  • added two Integation Tests to check if the metadatavalue is indexed.

Include guidance for how to test or review your PR.

  • create some metadatavalue with security level and try to search them using the discovery

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & integration tests). Exceptions may be made if previously agreed upon.
  • My PR passes Checkstyle validation based on the Code Style Guide.
  • My PR includes Javadoc for all new (or modified) public methods and classes. It also includes Javadoc for large or complex private methods.
  • My PR passes all tests and includes new/updated Unit or Integration Tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in any pom.xml), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR modifies REST API endpoints, I've opened a separate REST Contract PR related to this change.
  • If my PR includes new configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@floriangantner floriangantner force-pushed the issue452-skipsecuritylevel branch from 7063ecb to 218f605 Compare October 24, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant