Use pagination when updating CrisMetric records in index #516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshepherd
force-pushed
the
metric-update-pagination
branch
from
5d4d725 to
ba5b164
Compare
kshepherd
force-pushed
the
metric-update-pagination
branch
from
ba5b164 to
8a9d0f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
UpdateCrisMetricsInSolrDocServiceupdate method tries to read all metrics at once before processing and updating the index.In a system with a very large number of CrisMetrics DB rows, this can cause heap space errors.
This small PR adds a default page size of 1000 and reads pages in a while loop.