[cob_light] removed unused Boost signals dependency#406
Merged
fmessmer merged 1 commit into4am-robotics:kinetic_devfrom Dec 12, 2019
lopsided98:cob-light-boost-signals
Merged
[cob_light] removed unused Boost signals dependency#406fmessmer merged 1 commit into4am-robotics:kinetic_devfrom lopsided98:cob-light-boost-signals
fmessmer merged 1 commit into4am-robotics:kinetic_devfrom
lopsided98:cob-light-boost-signals
Conversation
Contributor
|
sounds reasonable just for my understanding: |
Contributor
Author
|
I am using Nix, but this problem will occur on any distribution with Boost >=1.69. This is the error message: Many ROS packages have this same problem: ros-planning/navigation#945, ros/geometry2#354, ros/geometry#180, moveit/moveit#1353, ros/ros_comm#1580, PR2/pr2_common_actions#39, ros-perception/calibration#43 |
This was referenced Dec 11, 2019
fmessmer
approved these changes
Dec 12, 2019
Contributor
fmessmer
left a comment
There was a problem hiding this comment.
thx for the patch and the explanation....I took care of other cob_* repos with the same problem....
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cob_lightdepends on Boost signals2, which is a header only library that does not need to be found usingfind_package. TheCMakeLists.txttries to find Boost signals (v1). This library was removed in Boost 1.69, causing this package to fail to build.