Add support for HIC v9 files, weight column and bump version #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added function to write hic normalizations to "weight" column in cooler file. VC, VC_SQRT and KR are inverted before put into weights. This is in line with the cooler-handling: https://github.com/open2c/cooler/blob/742e5c2adf6b6339ad6fcdb3e0a42449ee4e4675/src/cooler/api.py#L29
Author
|
In the last two commits, support for the weight-column in conversions was added as well, addressing issue #63. The normalization technique used for the weight column can be specified with the -N flag. Values for normalizations KR, VC, VC_SQRT, SCALE or whatever used, are inverted. This is because Cooler itself uses inverted values in the bin columns if the columns are named KR, VC, VC_SQRT |
VonAlphaBisZulu
changed the title
VonAlphaBisZulu
changed the title
Author
|
Anyone looked into this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing Issues #59 and #60. Possibly, also issues #56 and #57.
Tested with hic files in test_data to make sure the update doesn't break anything.