fix: fix typos in hybridse udf docstrings#4106
Open
isotauon wants to merge 1 commit into4paradigm:mainfrom
Open
fix: fix typos in hybridse udf docstrings#4106isotauon wants to merge 1 commit into4paradigm:mainfrom
isotauon wants to merge 1 commit into4paradigm:mainfrom
Conversation
Correct "begining"→"beginning", "charactors"→"characters", and "Negetive"→"Negative" in UDF doc comments for substring/substr/locate and the StrToIntegral helper.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4106 +/- ##
==========================================
Coverage 75.31% 75.32%
Complexity 711 711
==========================================
Files 763 763
Lines 143738 143738
Branches 2074 1480 -594
==========================================
+ Hits 108260 108266 +6
+ Misses 35175 35169 -6
Partials 303 303 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
SDK Test Report102 files ±0 102 suites ±0 2m 5s ⏱️ -6s Results for commit fa61609. ± Comparison against base commit f3c48e0. This pull request removes 30 and adds 9 tests. Note that renamed tests count towards both. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Small docstring typo fixes in
hybridse/src/udf/, in the spirit of #4085 / #4086:begining→beginning(×6)charactors→characters(×2)Negetive→Negative(×1)These appear in the doxygen-style
@param/@briefdoc comments forsubstring,substr, andlocateUDFs, plus a comment on theStrToIntegralhelper. No behavior change.Test plan