Merge pull request #8163 from 4teamwork/es/TI-2432-task-abort-workflow

Disallow to cancel tasks which are synced between multiple admin units.

Author: elioschmutz

changes/TI-2432.bugfix

@@ -0,0 +1 @@
+Disallow to cancel tasks which are synced between multiple admin units. [elioschmutz]

opengever/task/browser/transitioncontroller.py

@@ -303,11 +303,15 @@ def open_to_cancelled_guard(self, c, include_agency):
     def progress_to_cancelled_guard(self, c, include_agency):
         """Checks if:
         - The task is generated from tasktemplate and its the main task
+        - Task is not a predecessor or a successor
         - The current user is the issuer
         """
         if self.context.is_from_tasktemplate:
             return not ITask.providedBy(aq_parent(self.context))
 
+        if c.task.has_successors or (c.task.is_successor and not c.task.is_forwarding_successor):
+            return False
+
         if include_agency:
             return (c.current_user.is_issuer
                     or c.current_user.in_issuing_orgunits_inbox_group

opengever/task/tests/test_transitioncontroller.py

@@ -1,6 +1,9 @@
+from ftw.builder import Builder
+from ftw.builder import create
 from ftw.testbrowser import browsing
 from opengever.base.role_assignments import RoleAssignmentManager
 from opengever.base.role_assignments import SharingRoleAssignment
+from opengever.task.browser.accept.utils import accept_task_with_successor
 from opengever.task.browser.transitioncontroller import TaskTransitionController
 from opengever.tasktemplates.interfaces import IFromTasktemplateGenerated
 from opengever.testing import IntegrationTestCase
@@ -255,6 +258,43 @@ def test_only_available_for_tasktemplate_process_main_tasks(self):
         self.assertNotIn(
             self.transition, self.get_workflow_transitions_for(self.subtask))
 
+    @browsing
+    def test_not_available_for_predecessor_and_successor(self, browser):
+        self.login(self.dossier_responsible, browser)
+        predecessor = create(
+            Builder('task')
+            .within(self.dossier)
+            .having(issuer=self.dossier_responsible.id,
+                    responsible=self.regular_user.id,
+                    responsible_client='rk',
+                    task_type='correction')
+            .in_state('task-state-open')
+            .titled(u'Inquiry from a concerned citizen'))
+
+        sql_task = predecessor.get_sql_object()
+        with self.login(self.regular_user):
+            successor = accept_task_with_successor(
+                self.dossier,
+                'plone:%s' % sql_task.int_id,
+                u'I accept this task',
+            )
+
+        self.assertNotIn(self.transition, self.get_workflow_transitions_for(predecessor))
+        self.assertNotIn(self.transition, self.get_workflow_transitions_for(successor))
+
+    @browsing
+    def test_available_for_forwarding_successor(self, browser):
+        self.login(self.secretariat_user, browser)
+        forwarding_successor = create(
+            Builder('task')
+            .within(self.dossier)
+            .having(issuer=self.secretariat_user.id,
+                    responsible=self.regular_user.id,
+                    responsible_client='rk',
+                    task_type='correction')
+            .in_state('task-state-in-progress').successor_from(self.inbox_forwarding))
+        self.assertIn(self.transition, self.get_workflow_transitions_for(forwarding_successor))
+
 
 class TestInProgressResolvedGuard(BaseTransitionGuardTests):
     transition = 'task-transition-in-progress-resolved'