chore: marketplace api - #49
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 70995a5. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Introduces a new externally-facing webhook route and refactors signature verification logic; mistakes could allow spoofed events or drop valid deliveries in production.
Overview
Adds a new
POST /api/webhook/marketplacehandler for GitHubmarketplace_purchaseevents that verifies signatures usingGITHUB_MARKETPLACE_WEBHOOK_SECRETand records each accepted action to the audit trail (marketplace.*).Refactors GitHub webhook signature validation by moving env-var lookup/normalization and error responses into
verifyWebhookSignatureFromEnv(inlib/github/webhook-signature.ts), and updates the existing CLA bot webhook route to use this shared helper withGITHUB_WEBHOOK_SECRET(removing the route-local verification code).Reviewed by Cursor Bugbot for commit 6b62b48. Bugbot is set up for automated code reviews on this repo. Configure here.