fix: working on githb token expiring - #62
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit bdda7dc. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Medium Risk
Touches GitHub OAuth/session-adjacent flows and adds token refresh/rotation logic plus new user DB columns, which could affect login, authorization checks, and token revocation if misconfigured (e.g., missing GitHub App expiry setting).
Overview
Adds refreshable GitHub App user-token support by storing access+refresh tokens with expiries and a
githubTokenKinddiscriminator in theuserstable (new migration + schema updates).OAuth callback now requires GitHub’s expiring user tokens to be enabled, persists the token pair via
setUserGithubTokens, and downstream GitHub calls (admin authorization + bypass autocomplete) now obtain tokens through a newgetValidUserAccessTokenhelper that auto-refreshes/rotates tokens with concurrency guards.Logout now best-effort revokes the user’s GitHub App grant, clears stored token columns, and emits an audit event; Admin/Contributor pages add a re-auth banner when the user is on a legacy/non-refreshable token row. Docs were updated to clarify GitHub App credentials and the required token-expiry setting, and tests were updated/added for token refresh and updated mocks.
Reviewed by Cursor Bugbot for commit be1b9da. Bugbot is set up for automated code reviews on this repo. Configure here.