fix: fix pyright unnecessary type ignore comment#1266
Closed
Conversation
Deploying instructor-py with
|
| Latest commit: |
b07286c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6336b970.instructor-py.pages.dev |
| Branch Preview URL: | https://fix-pyright-ignore-errors.instructor-py.pages.dev |
Contributor
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to b07286c in 2 minutes and 16 seconds
More details
- Looked at
169lines of code in6files - Skipped
0files when reviewing. - Skipped posting
4drafted comments based on config settings.
1. instructor/batch.py:6
- Draft comment:
Unnecessary trailing comma in the dictionary definition. Remove it for cleaner code. - Reason this comment was not posted:
Confidence changes required:50%
The PR removes unnecessary type ignore comments for pydantic imports. This is a good change as it cleans up the code. However, there are some formatting issues that need to be addressed.
2. instructor/dsl/iterable.py:115
- Draft comment:
Unnecessary trailing comma in the set definition. Remove it for cleaner code. - Reason this comment was not posted:
Confidence changes required:50%
The PR removes unnecessary type ignore comments for pydantic imports. This is a good change as it cleans up the code. However, there are some formatting issues that need to be addressed.
3. instructor/multimodal.py:343
- Draft comment:
Unnecessary trailing comma in the list definition. Remove it for cleaner code. - Reason this comment was not posted:
Confidence changes required:50%
The PR removes unnecessary type ignore comments for pydantic imports. This is a good change as it cleans up the code. However, there are some formatting issues that need to be addressed.
4. instructor/batch.py:3
- Draft comment:
Since the pydantic import has been modified, please ensure that the relevant documentation and tests are updated accordingly. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_NgJqD43tKNjRP2CH
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Remove unnecessary
# type: ignorecomments frompydanticimports and adjust formatting in several files.# type: ignorefrompydanticimports inbatch.py,citation.py,iterable.py,maybe.py,validators.py, andmultimodal.py.batch.pyanditerable.py.multimodal.py.This description was created by
for b07286c. It will automatically update as commits are pushed.