Closed
Conversation
Guard Partial[T] creation against infinite recursion by tracking in-progress models and resolving forward refs. Add a regression test and changelog entry for the fix.
|
Cursor Agent can help with this pull request. Just |
github-actions
bot
added
bug
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
instructor | f24cbe9 | Commit Preview URL Branch Preview URL |
Jan 13 2026, 02:43 PM |
Exercise Partial[TreeNode] via model_from_chunks to prove recursive models work end-to-end instead of only through direct validation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: Stop Partial[T] from infinite recursion on self-referential models
Describe your changes
This change prevents
Partial[T]from entering infinite recursion when processing self-referential Pydantic models.The solution involves:
ForwardReffor recursive fields to break the immediate cycle.Partialmodel with a namespace that resolves these forward references, ensuring the schema remains finite.test_partial_handles_self_referential_models) to validate the fix.Issue ticket number and link
#1995
Checklist before requesting a review
Slack Thread