fix: patch OpenAI client in distil module to support dispatch mode#2032
Open
divyanshupatel17 wants to merge 1 commit into567-labs:mainfrom
Open
fix: patch OpenAI client in distil module to support dispatch mode#2032divyanshupatel17 wants to merge 1 commit into567-labs:mainfrom
divyanshupatel17 wants to merge 1 commit into567-labs:mainfrom
Conversation
Collaborator
|
I wonder if the right thing to do here is to actually allow the distillation tool to support any client that is an instructor client. This was implemented when opening; that was the only option, but we can go beyond this now. |
Author
|
Thanks for the feedback @jxnl ! Looking at "examples/distilations/three_digit_mul_dispatch.py" ,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
instructor.distilwhere theOpenAIclient was not being patched withinstructor, causingdispatchmode to fail becauseresponse_modelwas not recognized.instructor.distilintests/test_distil.pycovering key functionality includingget_signature_from_fn,format_function, and the@distildecorator in both usage modes.distil.pyto use top-level relative imports to avoid potential circular dependencies.Issue ticket number and link
(None)
Checklist before requesting a review