fix(validation): fix unreachable allow_override code in llm_validator#2038
Open
Waqar53 wants to merge 2 commits into567-labs:mainfrom
Open
fix(validation): fix unreachable allow_override code in llm_validator#2038Waqar53 wants to merge 2 commits into567-labs:mainfrom
Waqar53 wants to merge 2 commits into567-labs:mainfrom
Conversation
The allow_override feature was completely broken - the assert on line 69 would raise AssertionError before the override check on lines 71-73 could ever execute. Changes: - Restructure logic so allow_override check runs before any exception - Use ValueError instead of assert for better error handling - Update docstring to match actual parameters - Add 5 comprehensive tests for allow_override functionality Fixes the documented allow_override feature that was previously dead code.
jxnl
reviewed
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a critical bug where the allow_override feature in llm_validator() was completely broken - the code was unreachable dead code due to an
assertstatement.The Bug