Draft
Conversation
Avoid importing google.generativeai at module import time so projects that don't use the legacy Gemini client won't see upstream FutureWarning noise. Adds a regression test that guards against importing google.generativeai during import instructor and bumps version to 1.14.6. Co-authored-by: jason <jason@jxnl.co>
|
Cursor Agent can help with this pull request. Just |
github-actions
bot
added
bug
Run ruff format and update uv.lock after bumping version and adding the regression test. Co-authored-by: jason <jason@jxnl.co>
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
instructor | e1f3c7d | Commit Preview URL Branch Preview URL |
Jan 31 2026, 02:32 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: Lazy load
google.generativeaiand bump version to 1.14.6Describe your changes
This PR addresses an issue where
google.generativeaiwas eagerly imported duringimport instructor, causing aFutureWarningeven when the Gemini client was not actively used.Changes include:
google.generativeailazy withininstructor/providers/gemini/client.pyso it's only imported whenfrom_geminiis called.tests/test_gemini_imports.py) to ensuregoogle.generativeaiis not imported atinstructormodule import time.1.14.5to1.14.6ininstructor/__init__.pyandpyproject.toml.CHANGELOG.mdto reflect the fix.uv.lockwith dependency changes (e.g.,anthropicupdate).Issue ticket number and link
N/A
Checklist before requesting a review