Skip to content

fix(process_response): use issubclass instead of isinstance for ParallelBase check #2058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mr-Neutr0n wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(process_response): use issubclass instead of isinstance for ParallelBase check #2058

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions instructor/processing/response.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ async def process_response_async(
raw_response=response,
)

if isinstance(response_model, ParallelBase):
if inspect.isclass(response_model) and issubclass(response_model, ParallelBase):
logger.debug(f"Returning model from ParallelBase")
model._raw_response = response
return model
Expand Down Expand Up @@ -381,7 +381,7 @@ class to parse the response into. Special DSL types supported:
raw_response=response,
)

if isinstance(response_model, ParallelBase):
if inspect.isclass(response_model) and issubclass(response_model, ParallelBase):
logger.debug(f"Returning model from ParallelBase")
model._raw_response = response
return model
Expand Down
Loading