fix(templating): return kwargs instead of None in handle_templating#2073
Open
Waqar53 wants to merge 2 commits into567-labs:mainfrom
Open
fix(templating): return kwargs instead of None in handle_templating#2073Waqar53 wants to merge 2 commits into567-labs:mainfrom
Waqar53 wants to merge 2 commits into567-labs:mainfrom
Conversation
Fixed missing return values in handle_templating() function. Previously, the function returned None implicitly in two early-exit cases, which could cause unexpected behavior for callers. - Line 122: Return kwargs when messages list is empty - Line 127: Return kwargs when no messages found in dict
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed missing return values in handle_templating() function. Previously, the function returned None implicitly in two early-exit cases, which could cause unexpected behavior for callers.