[codex] consolidate docs and audio validation fixes#2400
Draft
jxnl wants to merge 1 commit into
Draft
Conversation
This was referenced Jun 29, 2026
Closed
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
instructor | 15e9f4a | Commit Preview URL Branch Preview URL |
Jun 29 2026, 04:57 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidates four compact, low-risk maintenance fixes from the open queue:
assertvalidation inAudio.from_url()andAudio.from_path()with explicitValueError/FileNotFoundError, matching the existingImage/PDFbehavior. Supersedes fix(multimodal): raise explicit errors in Audio instead of assert #2361.Superseded PRs / Issues
Validation
git diff --checkUV_CACHE_DIR=/private/tmp/uv-cache uv run pytest tests/v2/test_core_multimodal_runtime.py -q-> 23 passedUV_CACHE_DIR=/private/tmp/uv-cache uv run ruff check instructor/v2/core/multimodal.py tests/v2/test_core_multimodal_runtime.py examples/crm/run.pyuv.lockcheck skipped, dependency install/export hooks skipped,typassedSkipped Items
Skipped as too broad for this consolidation pass:
Draft Release Notes
assert, so invalid audio inputs are rejected consistently even when Python runs with optimizations enabled.Draft Tweet
small instructor cleanup this week
fixed audio validation so it does not depend on python asserts, cleaned up a few google docs lies, and patched a couple tiny docs papercuts
not flashy, but this is the kind of maintenance that keeps examples and error paths honest