fix: robust JSON extraction for mixed LLM responses#124
Open
SergioChan wants to merge 1 commit into666ghj:mainfrom
Open
fix: robust JSON extraction for mixed LLM responses#124SergioChan wants to merge 1 commit into666ghj:mainfrom
SergioChan wants to merge 1 commit into666ghj:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SummarynnHarden backend JSON parsing for LLM responses so mixed outputs (markdown fences, pre/post text) are handled more robustly, reducing 500 errors reported during ontology generation.nn## Changesnn- Updated
LLMClient.chat()to remove<think ...>...</think>tags case-insensitivelyn- AddedLLMClient._extract_json_payload()to normalize and extract JSON from noisy model responsesn- Updatedchat_json()to parse extracted payload instead of raw contentn- Added unit tests inbackend/tests/test_llm_client_json_extract.pyfor fenced JSON and mixed-text extractionnn## Testingnn- Added targeted unit tests for extraction behaviorn- Could not execute tests in this environment because backend dev dependencies are not installed (pytest,flaskmissing)nnFixes #64