feat: Add custom exceptions and enhanced config validation#126
Open
ZaviQ7 wants to merge 1 commit into666ghj:mainfrom
Open
feat: Add custom exceptions and enhanced config validation#126ZaviQ7 wants to merge 1 commit into666ghj:mainfrom
ZaviQ7 wants to merge 1 commit into666ghj:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the robustness of the MiroFish backend by implementing two key architectural improvements:
1. Custom Exception Hierarchy
MiroFishErrorbase class with error codes, severity levels, and HTTP status codes.2. Enhanced Configuration Validation
Config.validate_comprehensive()to check for valid URL formats, numeric ranges, and placeholder API keys.Testing
backend/tests/test_exceptions.pyandbackend/tests/test_config_validated.py.