Skip to content

gpt-5 support - #112

Merged
priyanshujain merged 1 commit into
masterfrom
fix-gpt-5-support
Aug 31, 2025
Merged

gpt-5 support#112
priyanshujain merged 1 commit into
masterfrom
fix-gpt-5-support

Conversation

@priyanshujain

@priyanshujain priyanshujain commented Aug 31, 2025

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • New Features
    • Added compatibility with OpenAI gpt-5 models, with automatic handling of temperature and token limits consistent with other reasoning models.
  • Chores
    • Updated default model selections:
      • OpenAI default: openai:gpt-5 (replaces openai:gpt-4o).
      • Anthropic default: anthropic:claude-sonnet-4-20250514 (replaces anthropic:claude-3-5-sonnet-20241022).
    • Minor improvements to API key validation behavior for gpt-5 models.

@coderabbitai

coderabbitai Bot commented Aug 31, 2025

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

Walkthrough

Updates add gpt-5 handling to the OpenAI provider by aligning parameter logic with o4/o1, and adjust default model selections in credential resolution: OpenAI now defaults to gpt-5, and Anthropic to claude-sonnet-4-20250514. No public API signatures change.

Changes

Cohort / File(s) Summary of Changes
OpenAI provider parameter handling
cli/src/infragpt/llm/providers/openai_provider.py
Treat gpt-5 like o4/o1 in API key validation and request construction: use max_completion_tokens instead of max_tokens; default temperature branch includes gpt-5.
Default model selection
cli/src/infragpt/main.py
Update defaults in get_credentials_v2: OpenAI default from openai:gpt-4o to openai:gpt-5; Anthropic default from anthropic:claude-3-5-sonnet-20241022 to anthropic:claude-sonnet-4-20250514.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant CLI as CLI get_credentials_v2
  participant Cfg as Env/Config

  User->>CLI: Invoke command (no model_string)
  CLI->>Cfg: Read provider env/config
  alt Provider = openai
    CLI->>CLI: Set default model = openai:gpt-5
  else Provider = anthropic
    CLI->>CLI: Set default model = anthropic:claude-sonnet-4-20250514
  end
  CLI-->>User: Credentials + selected default model
Loading
sequenceDiagram
  autonumber
  participant Client as OpenAIProvider
  participant Builder as _build_request
  participant API as OpenAI API

  Client->>Builder: Build chat/completions request (model, kwargs)
  alt Model starts with o4/o1/gpt-5
    note right of Builder: Uses max_completion_tokens<br/>Temperature defaults to 1.0 unless specified
    Builder->>API: {model, messages, max_completion_tokens, (temperature?)}
  else Other models
    note right of Builder: Uses max_tokens<br/>Temperature from kwargs (default 0.0)
    Builder->>API: {model, messages, max_tokens, temperature}
  end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I twitch my ears at version five,
New defaults hop where prompts arrive.
Tokens split by model kind,
Cool or warm, the temps aligned.
With keys in paw, I test and see—
A snappy leap for LLM spree! 🐇✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between f466de4 and 487b75e.

📒 Files selected for processing (2)
  • cli/src/infragpt/llm/providers/openai_provider.py (2 hunks)
  • cli/src/infragpt/main.py (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-gpt-5-support

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@priyanshujain
priyanshujain merged commit 7e5c374 into master Aug 31, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant