Skip to content

fix(ci): review draft pull requests without backlog #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
777genius merged 1 commit into from
Jul 16, 2026
Merged

fix(ci): review draft pull requests without backlog #281

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions .github/workflows/reviewrouter-codex.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ name: ReviewRouter Codex OAuth

on:
pull_request:
types: [opened, synchronize, reopened, ready_for_review]
types: [opened, synchronize, reopened, ready_for_review, converted_to_draft]
pull_request_target:
types: [opened, synchronize, reopened, ready_for_review]
types: [opened, synchronize, reopened, ready_for_review, converted_to_draft]
workflow_dispatch:
schedule:
- cron: "17 */6 * * *"
Expand All @@ -18,7 +18,6 @@ jobs:
timeout-minutes: ${{ fromJSON(vars.REVIEW_ROUTER_TIMEOUT_MINUTES || '60') }}
concurrency:
group: reviewrouter-codex-oauth-${{ github.repository_id }}-codex-rotating-1163183284
queue: max
cancel-in-progress: false
Comment on lines 19 to 21

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 16, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restore ReviewRouter queueing for pending runs

When a ReviewRouter job is already running and two or more PR events or refreshes arrive, removing queue: max makes this concurrency group fall back to GitHub Actions' default single pending run, where a newer pending run cancels/replaces the existing pending run (the GitHub concurrency docs describe queue: max as the option that allows up to 100 pending runs). Because codex-review and codex-refresh share this same group, bursts of ReviewRouter events can now silently drop reviews or refreshes; the same restoration is needed in the refresh block below.

Useful? React with 馃憤聽/ 馃憥.

if: ${{ ((github.event_name == 'pull_request' && github.event.pull_request.draft == false) || (github.event_name == 'pull_request_target' && github.event.pull_request.draft == true && vars.REVIEW_ROUTER_REVIEW_DRAFTS == 'true')) && github.event.pull_request.head.repo.full_name == github.repository && github.event.pull_request.user.type != 'Bot' }}
permissions:
Expand All @@ -43,7 +42,6 @@ jobs:
timeout-minutes: 60
concurrency:
group: reviewrouter-codex-oauth-${{ github.repository_id }}-codex-rotating-1163183284
queue: max
cancel-in-progress: false
if: ${{ github.event_name == 'schedule' || github.event_name == 'workflow_dispatch' }}
permissions:
Expand Down
Loading