Add support for the Waveshare ESP32-C6-Touch-AMOLED-2.06 third-party board #1342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
这个 GetBacklight 跟 waveshare-c6-touch-amoled-1.43 的实现一致。 然而，waveshare-s3-touch-amoled-1.75 与 waveshare-s3-touch-amoled-2.06 是另外一种实现方式，看起来是同一个屏幕，可否统一为后者呢？甚至可以作为一个公共的class引入。 |
Contributor
Author
|
AMOLED屏幕大多数是通过屏幕写寄存器控制背光的，逻辑都是一个逻辑。 |
Owner
|
可以使用统一的方案，waveshare-s3-touch-amoled-1.75 与 waveshare-s3-touch-amoled-2.06 的 CustomBacklight 的方案可能更好。 |
Contributor
Author
|
好的，我会修改，预计下周内处理好 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tested.