ESP-P4-Function-EV-Board add SD card, camera, and font initialization #1403
+111
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd display handling
…uch and SD card support
Removed ESP hosted configuration options.
…d updated configurations
…updated configurations
…detailed features; add SD card, camera, and font initialization in esp-p4-function-ev-board.cc
There was a problem hiding this comment.
Pull Request Overview
This PR adds hardware initialization support for the ESP-P4-Function-EV-Board, including SD card mounting, camera initialization, and font verification functionality. The changes enhance the board's feature set by enabling additional peripherals and updating documentation to reflect these capabilities.
- Adds three new initialization methods for SD card, camera, and fonts
- Updates destructor to handle SD card cleanup
- Expands README documentation to list all supported hardware features
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| main/boards/esp-p4-function-ev-board/esp-p4-function-ev-board.cc | Adds SD card, camera, and font initialization methods; includes SD card unmount in destructor and new include for LVGL theme support |
| main/boards/esp-p4-function-ev-board/README.md | Expands feature documentation to include detailed hardware support (audio, touch, SD card, camera, USB, SPIFFS, fonts) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
main/boards/esp-p4-function-ev-board/esp-p4-function-ev-board.cc
Outdated
Show resolved
Hide resolved
main/boards/esp-p4-function-ev-board/esp-p4-function-ev-board.cc
Outdated
Show resolved
Hide resolved
Comment on lines
103
to
113
| void InitializeCamera() | ||
| { | ||
| ESP_LOGI(TAG, "Initializing camera"); | ||
| bsp_camera_cfg_t camera_cfg = {0}; | ||
| esp_err_t ret = bsp_camera_start(&camera_cfg); | ||
| if (ret != ESP_OK) { | ||
| ESP_LOGE(TAG, "Failed to initialize camera: %s", esp_err_to_name(ret)); | ||
| } else { | ||
| ESP_LOGI(TAG, "Camera initialized successfully"); | ||
| } | ||
| } |
There was a problem hiding this comment.
The camera is initialized but never exposed through a GetCamera() method, and there's no cleanup in the destructor. This means:
- The initialized camera resources cannot be accessed by the application
- Camera resources may leak on board destruction
Consider either:
- Adding a
virtual Camera* GetCamera() overridemethod that returns a Camera wrapper for the BSP camera - Adding camera cleanup in the destructor (e.g.,
bsp_camera_stop()if available) - Removing the camera initialization if the camera functionality is not yet ready to be used
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
…ck configuration for direct camera setup and update README for clarity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove ESP-P4-Function-EV-Board configuration and update README with detailed features; add SD card, camera, and font initialization in esp-p4-function-ev-board.cc