Skip to content

Fix flaky 'enqueue with progress' integration test #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2025
Merged

Fix flaky 'enqueue with progress' integration test #571

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions example/integration_test/general_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,8 +201,8 @@ void main() {
expect(await FileDownloader().enqueue(task), isTrue);
await progressCallbackCompleter.future;
// because google.com has no content-length, we only expect the 0.0 and
// 1.0 progress update
expect(progressCallbackCounter, equals(2));
// 1.0 progress update, but sometimes we get more
expect(progressCallbackCounter, greaterThanOrEqualTo(2));
expect(lastValidExpectedFileSize, equals(-1));
await statusCallbackCompleter.future;
expect(statusCallbackCounter, equals(3));
Expand Down