Skip to content

Relax restriction on .modify call after .from in ModuleDef DSL, allow widening implementation type. Apply .namedByImpl after modifications, not before#2221

Draft
neko-kai wants to merge 4 commits into
developfrom
feature/relax-functoid-modify
Draft

Relax restriction on .modify call after .from in ModuleDef DSL, allow widening implementation type. Apply .namedByImpl after modifications, not before#2221
neko-kai wants to merge 4 commits into
developfrom
feature/relax-functoid-modify

Conversation

@neko-kai
Copy link
Copy Markdown
Member

No description provided.

… widening implementation type. Apply .namedByImpl after modifications, not before
@neko-kai neko-kai requested a review from pshirshov as a code owner November 29, 2024 17:12
@neko-kai neko-kai marked this pull request as draft November 29, 2024 17:20
@neko-kai
Copy link
Copy Markdown
Member Author

neko-kai commented Nov 29, 2024

Hmm, has implications on losing integration checks after .modify. Maybe after #1658 ?

Hmm, can't ordinary .modify also lose integration checks? (it can't after #2255)

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.63%. Comparing base (a8cfd4b) to head (9648c97).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2221   +/-   ##
========================================
  Coverage    66.63%   66.63%           
========================================
  Files          594      594           
  Lines        11679    11679           
  Branches      1317     1399   +82     
========================================
  Hits          7782     7782           
  Misses        3897     3897           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant