LogStage: logMethod support #2266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikita-ty754
force-pushed
the
feature/logstage-log-method
branch
from
fd6fcc2 to
e4344a9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2266 +/- ##
===========================================
+ Coverage 66.65% 66.71% +0.06%
===========================================
Files 597 601 +4
Lines 11732 11805 +73
Branches 1317 1326 +9
===========================================
+ Hits 7820 7876 +56
- Misses 3912 3929 +17 🚀 New features to boost your workflow:
|
neko-kai
reviewed
Apr 23, 2025
| logImplicits: Boolean, | ||
| qp: c.Expr[QuasiIO[F]], | ||
| ): c.Expr[F[A]] = { | ||
| val (variables, logString) = createVariablesAndLogStringTrees(function, logTypes, logImplicits) |
There was a problem hiding this comment.
Suggested change
| val (variables, logString) = createVariablesAndLogStringTrees(function, logTypes, logImplicits) | |
| logMethodIOF(level, c.Expr[F[A]](q"$qp.maybeSuspend($function)"), logTypes, logImplicits, qp) |
Should work, since c.Expr[QuasiIO[F]] is <: c.Expr[QuasiPrimitives[F]]
neko-kai
reviewed
Apr 23, 2025
logstage/logstage-core/src/main/scala-3/izumi/logstage/api/logger/AbstractMacroLogIO.scala
Outdated
Show resolved
Hide resolved
- logMethod test - use default parameters in scala3 macro
def add(x: Int) ... def add(x: Int, y: Int) ...
neko-kai
force-pushed
the
feature/logstage-log-method
branch
from
719359c to
36e9466
Compare
…ggers/LogIOMacroLoggers, add logMethod* for Raw and Strict loggers, fix bug: fully qualify Log.Entry in LogMethodMacro
…he log string. Remove redundant `getMethodBySignature` - just use m.symbol.asMethod
…thodF. Allow named parameters and runtime values for printTypes and printImplicits in logMethod/F. Add Strict/Raw variants for logMethod/F. Add AbstractLogIO.widenError. Fully unify default/Strict/Raw loggers, remove AbstractMacroLogger* variant traits. Add more tests.
…e they are now constant vals inside the prefix object
…t* copypaste, read printTypes/printImplicits at runtime, assemble messages at runtime, merge getMethodArguments/getMethodSymbol loops into a single loop
…, add "using" to implicit parameter list in log, add LogstageCodec for Unit, add LogIORaw2/3 type aliases. Add test that side-effects in logger argument do not happen twice when logging is disabled and that side effects in implicits do not happen twice when printImplicits is disabled. Check that evaluation of level,printTypes,printImplicits parameters only happens once. test strict/raw logIO loggers. test logIO.logValues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2157