Deprecate make without .from, use make[T].fromSelf instead#2349
Open
neko-kai wants to merge 1 commit into
Open
Deprecate make without .from, use make[T].fromSelf instead#2349neko-kai wants to merge 1 commit into
make without .from, use make[T].fromSelf instead#2349neko-kai wants to merge 1 commit into
Conversation
Supporting `make[T]` syntax without a follow-up `from` is rife with issues (see scala/scala3#21622) Ports of distage to [Python](https://github.com/7mind/izumi-chibi-py) and [TypeScript](https://github.com/7mind/izumi-chibi-ts) do not support solitary `make` and that seems to work out just fine. Commit is generated and needs cleanup/review before merge.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #2349 +/- ##
===========================================
+ Coverage 67.83% 67.84% +0.02%
===========================================
Files 635 635
Lines 12808 12857 +49
Branches 1475 1486 +11
===========================================
+ Hits 8687 8722 +35
- Misses 4121 4135 +14 🚀 New features to boost your workflow:
|
Member
Author
|
Maybe we should use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supporting
make[T]syntax without a follow-upfromis rife with issues (see scala/scala3#21622) Ports of distage to Python and TypeScript do not support solitarymakeand that seems to work out just fine.Commit is generated and needs cleanup/review before merge.