Skip to content

fix: show only running containers in force-delete prompt #1987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xz-dev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: show only running containers in force-delete prompt #1987

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 21 additions & 13 deletions distrobox-rm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,32 +418,40 @@ else
response="yes"
fi

# Collect running containers first
running_containers=""
for container in ${container_name_list}; do
if [ "$(${container_manager} inspect --type container --format '{{.State.Status}}' "${container}")" = "running" ]; then
if [ "${non_interactive}" -eq 0 ] && [ "${force}" -eq 0 ]; then
printf "Container %s running, do you want to force delete them? [Y/n]: " "${container_name_list}"
read -r response_force
response_force="${response_force:-"Y"}"
else
response_force="yes"
fi
running_containers="${running_containers} ${container}"
fi
done

# If there are running containers, ask once for all of them
if [ -n "${running_containers}" ]; then
if [ "${non_interactive}" -eq 0 ] && [ "${force}" -eq 0 ]; then
printf "Containers%s are running, do you want to force delete them? [Y/n]: " "${running_containers}"
read -r response_force
response_force="${response_force:-"Y"}"
else
response_force="yes"
fi

# Accept only y,Y,Yes,yes,n,N,No,no.
case "${response_force:-"N"}" in
case "${response_force}" in
y | Y | Yes | yes | YES)
force=1
force_flag="--force"
break
;;
n | N | No | no | NO) ;;

*) # Default case: If no more options then break out of the loop.
n | N | No | no | NO)
# Continue without force flag - running containers will fail to delete
;;
*)
printf >&2 "Invalid input.\n"
printf >&2 "The available choices are: y,Y,Yes,yes,YES or n,N,No,no,NO.\nExiting.\n"
exit 1
;;
esac
done
fi

# Accept only y,Y,Yes,yes,n,N,No,no.
case "${response}" in
Expand Down