Skip to content

feat: Implement "Remove" action on exported apps to delete them#2061

Open
iTrooz wants to merge 5 commits into
89luca89:nextfrom
iTrooz:next_del_exported_app
Open

feat: Implement "Remove" action on exported apps to delete them#2061
iTrooz wants to merge 5 commits into
89luca89:nextfrom
iTrooz:next_del_exported_app

Conversation

@iTrooz
Copy link
Copy Markdown

@iTrooz iTrooz commented Apr 20, 2026

See #2059
Same feature but targeting next branch

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Implements a “Remove” desktop action for exported app launchers so users can delete exported shortcuts, and extends distrobox list to optionally target a single container (used by the new remove action to decide whether to run in-container deletion or remove the desktop file directly).

Changes:

  • Add a “Remove” desktop action to exported .desktop files in distrobox-export.
  • Extend ListCommand.Execute / distrobox list to accept an optional [container-name] filter and return a not-found error when specified and missing.
  • Update call sites and documentation/manpage to reflect the new list behavior.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
pkg/commands/list.go Add ListOptions filtering and not-found error behavior.
internal/cli/list.go Accept optional container-name arg and pass it to ListCommand.
internal/inside-distrobox/assets/distrobox-export Append a “Remove” desktop action that triggers deletion logic.
pkg/commands/upgrade.go Update to new ListCommand.Execute(ctx, opts) signature.
pkg/commands/stop.go Update to new ListCommand.Execute(ctx, opts) signature.
pkg/commands/rm.go Update to new ListCommand.Execute(ctx, opts) signature.
pkg/commands/generate_entry.go Update to new ListCommand.Execute(ctx, opts) signature.
pkg/commands/generate_entry_test.go Update test to new ListCommand.Execute(ctx, opts) signature.
docs/usage/distrobox-list.md Document optional [container-name] argument.
man/man1/distrobox-list.1 Document optional [container-name] argument and add an example.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread internal/inside-distrobox/assets/distrobox-export
Comment thread pkg/commands/list.go Outdated
Comment thread pkg/commands/rm.go
Comment thread pkg/commands/list.go
Comment thread internal/inside-distrobox/assets/distrobox-export
Comment thread internal/inside-distrobox/assets/distrobox-export
Comment thread internal/inside-distrobox/assets/distrobox-export
@iTrooz
Copy link
Copy Markdown
Author

iTrooz commented Apr 23, 2026

Done

@iTrooz iTrooz force-pushed the next_del_exported_app branch from 1d99b75 to 3e166b0 Compare May 5, 2026 12:11
@iTrooz
Copy link
Copy Markdown
Author

iTrooz commented May 5, 2026

Just resolved the conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants