feat: Implement "Remove" action on exported apps to delete them#2061
Open
iTrooz wants to merge 5 commits into
Open
feat: Implement "Remove" action on exported apps to delete them#2061iTrooz wants to merge 5 commits into
iTrooz wants to merge 5 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Implements a “Remove” desktop action for exported app launchers so users can delete exported shortcuts, and extends distrobox list to optionally target a single container (used by the new remove action to decide whether to run in-container deletion or remove the desktop file directly).
Changes:
- Add a “Remove” desktop action to exported
.desktopfiles indistrobox-export. - Extend
ListCommand.Execute/distrobox listto accept an optional[container-name]filter and return a not-found error when specified and missing. - Update call sites and documentation/manpage to reflect the new list behavior.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/commands/list.go | Add ListOptions filtering and not-found error behavior. |
| internal/cli/list.go | Accept optional container-name arg and pass it to ListCommand. |
| internal/inside-distrobox/assets/distrobox-export | Append a “Remove” desktop action that triggers deletion logic. |
| pkg/commands/upgrade.go | Update to new ListCommand.Execute(ctx, opts) signature. |
| pkg/commands/stop.go | Update to new ListCommand.Execute(ctx, opts) signature. |
| pkg/commands/rm.go | Update to new ListCommand.Execute(ctx, opts) signature. |
| pkg/commands/generate_entry.go | Update to new ListCommand.Execute(ctx, opts) signature. |
| pkg/commands/generate_entry_test.go | Update test to new ListCommand.Execute(ctx, opts) signature. |
| docs/usage/distrobox-list.md | Document optional [container-name] argument. |
| man/man1/distrobox-list.1 | Document optional [container-name] argument and add an example. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Author
|
Done |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
1d99b75 to
3e166b0
Compare
Author
|
Just resolved the conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #2059
Same feature but targeting
nextbranch